CPU support #82
Open
CPU support #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swapped out CUDA params for CPU support
|
Hi @esteininger, I am new to this repo, so maybe this is a naive question, does it work with CPU? I mean, with this patch, is it able to generate a response in a reasonable time? And does it work for both training and inferencing? BTW, I don't think the owner of this repo would accept this kind of functionality change. If it works with CPU, maybe making the behaviour controlled by an optional parameter specified somewhere (command line, or environment variable, or configuraiton file) is a better approach. Just my two cents. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swapped out CUDA params for CPU support