Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Updated SubDao functionality to have members count and an active threshold #808

Closed

Conversation

theghostmac
Copy link

@theghostmac theghostmac commented Mar 12, 2024

This pull request addresses the issue #781 "Support active_threshold in dao-voting-cw4" by updating the SubDao functionality to include a member count and an active threshold.

This ensures that SubDAOs can only be considered active if they meet the minimum required member count specified by the active threshold.

@theghostmac
Copy link
Author

Can I redirect this PR to a separate branch? Seeing that development is the default..

@JakeHartnell
Copy link
Member

JakeHartnell commented Mar 12, 2024

This pull request addresses the issue #781 "Support active_threshold in dao-voting-cw4" by updating the SubDao functionality to include a member count and an active threshold.

This PR is not exactly what I had in mind when I wrote the ticket which is my bad as I should have included more detail. The contract that needs to be modified is contracts/voting/dao-voting-cw4. There are examples of implementing active threshold in contracts/voting/dao-voting-cw721-staked and contracts/voting/dao-voting-token-staked, use those for reference.

Additionally, we try not to touch the core module unless we absolutely have to due to audit costs.

This PR just adds some metadata around this, but the core-active threshold logic is in the voting module contracts. Going to close for now, but happy to find time to chat about this issue if you want to take it on!

@theghostmac theghostmac deleted the ghostmac/update-subdao branch April 6, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants