Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Upgrade to Node 18 and clean up dependencies #40

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ehrhart
Copy link
Contributor

@ehrhart ehrhart commented Aug 29, 2024

This pull request includes upgrades and dependency changes:

  • Set Node.js version requirement to >=18.0.0.
  • Upgrade eslint-plugin-import to 2.29.1.
  • Remove unnecessary dependency rimraf.
  • Replace certain dependencies with native Node.js functions:
    • Use fetch instead of axios for making HTTP requests.
    • Use fs instead of is-valid-path for checking if a path is valid.
    • Use node:assert and node:test instead of ava and nock for testing.

This also results in a significant decrease in bundle size:

Package Size Minified Gzipped
[email protected] 214.76 KB 59.86 KB 21.07 KB
sparql-transformer@refactor/dependencies-and-upgrade 27.22 KB (-87.33%) 9.87 KB (-83.51%) 4.07 KB (-80.69%)

- Remove unnecessary dependency `rimraf`.
- Use `fetch` instead of `axios` for making HTTP requests.
- Use `fs` instead of `is-valid-path` for checking if a path is valid.
- Use `node:assert` and `node:test` instead of `ava` and `nock` for
testing.
- Set Node.js version requirement to >=18.0.0.
- Use `https` instead of `http` for the default DBpedia endpoint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant