Registers COPY TO/FROM parquet hooks #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
aykut-bozkurt
commented
Oct 2, 2024
aykut-bozkurt
commented
- Registers COPY TO/FROM parquet hooks,
- Adds a GUC, named "pg_parquet.enable_copy_hooks", which enables/disabled the hook,
- Exposes parquet dest receiver api so that the dest receiver could be used independently from the hook.
marcoslot
reviewed
Oct 2, 2024
| .catch_others(|cause| { | ||
| // make sure to pop the parquet reader context | ||
| let throw_error = false; | ||
| pop_parquet_reader_context(throw_error); |
There was a problem hiding this comment.
since we don't push it above, can we be sure that it was actually pushed before we get here?
There was a problem hiding this comment.
we pass let throw_error = false; in case it is not pushed yet. This will prevent throwing error. (will print debug message)
There was a problem hiding this comment.
ok, could use a comment. Ideally we pop where we push, such that we always maintain the stack correctly. Though since the stack covers a niche use case, it's probably ok to hand wave a little as long as it's somewhat documented.
- registers COPY TO/FROM parquet hook, - adds a GUC, named "pg_parquet.enable_copy_hooks", which enables/disabled the hook, - exposes parquet dest receiver api so that the dest receiver could be used independently from the hook.
aykut-bozkurt
force-pushed
the
copy-from-api
branch
from
fb0a773
to
1db4ee9
Compare
aykut-bozkurt
force-pushed
the
copy-hooks
branch
from
f4ce50d
to
fc36148
Compare
|
Addressed at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.