COPY FROM api #31
Closed
COPY FROM api #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoslot
reviewed
Oct 2, 2024
| } | ||
|
|
||
| let attlist = copy_attlist(&pstmt); | ||
| let attnamelist = copy_attnames(&pstmt); |
There was a problem hiding this comment.
since this lo longer correspond to postgres code, can probably afford to just write attribute_name_list to make it easier to digest, e.g. I like the verbosity of the function above
marcoslot
reviewed
Oct 2, 2024
| } | ||
|
|
||
| #[pg_guard] | ||
| extern "C" fn copy_received_parquet_data_to_buffer( |
marcoslot
reviewed
Oct 2, 2024
| bytes_to_copy as _ | ||
| } | ||
|
|
||
| pub(crate) fn execute_copy_from( |
There was a problem hiding this comment.
this function is especially wild, could use a comment on what's going on here, and e.g. what copy_received_parquet_data_to_buffer is for / why we need it
We internally use Postgres binary protocol to populate tables from parquet file.
aykut-bozkurt
force-pushed
the
copy-to-api
branch
from
762cf82
to
b71a602
Compare
aykut-bozkurt
force-pushed
the
copy-from-api
branch
from
fb0a773
to
1db4ee9
Compare
|
Addressed at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds COPY FROM parquet api, which internally uses Postgres binary protocol to populate tables from parquet file.