Add crunchy_map type conversion from/to arrow #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoslot
reviewed
Oct 2, 2024
| .expect("expected crunchy_map is created"); | ||
|
|
||
| let found_typoid = unsafe { | ||
| GetSysCacheOid( |
There was a problem hiding this comment.
can we do Oid -> Oid2 to omit the last 2 arguments?
marcoslot
reviewed
Oct 2, 2024
| TYPEOID as _, | ||
| Anum_pg_type_oid as _, | ||
| typoid.into_datum().unwrap(), | ||
| crunchy_map_ext_schema_oid.into_datum().unwrap(), |
There was a problem hiding this comment.
I'm a bit confused about this GetSysCacheOid call. As far as I can tell the TYPEOID only looks up by type OID, not schema OID.
marcoslot
reviewed
Oct 2, 2024
| } | ||
|
|
||
| impl IntoDatum for CrunchyMap<'_> { | ||
| fn into_datum(self) -> Option<pg_sys::Datum> { |
There was a problem hiding this comment.
would still appreciate more comments, e.g.
// since the map is stored as an array of tuples, we can simply convert the array to a datum
aykut-bozkurt
force-pushed
the
wkb-conversion
branch
from
4e7faf8
to
3041298
Compare
aykut-bozkurt
force-pushed
the
crunchy-map-conversion
branch
from
1315215
to
d0a1773
Compare
|
Addressed at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.