Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handles empty firewall rule description - BR-2812 #173

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

ngaumont
Copy link
Contributor

No description provided.

@ngaumont ngaumont requested a review from a team as a code owner September 27, 2024 08:19
Copy link
Member

@abrightwell abrightwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a couple comments.

CHANGELOG.md Outdated Show resolved Hide resolved
spec/cb/firewall_rule_spec.cr Outdated Show resolved Hide resolved
@ngaumont ngaumont merged commit 1bb3611 into main Oct 24, 2024
2 checks passed
@ngaumont ngaumont deleted the empty-description branch October 24, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants