Add firewall rule management to cb network command.
#168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrightwell
force-pushed
the
abrightwell/network-firewall-command
branch
from
53ad389
to
4eefc52
Compare
These changes move firewall rule management under `cb network` and deprecate the `cb firewall` rule command. This comes as part of a request to be able to update firewall rules more completely as described in #161. The following commands are now supported: * `cb network add-firewall-rule` * `cb network list-firewall-rules` * `cb network remove-firewall-rule` * `cb network update-firewall-rule` Each command requires the specification of the network to peform the operation. As well, the shell completion logic has been updated to suggest the list of available networks and firewall rule when applicable.
abrightwell
force-pushed
the
abrightwell/network-firewall-command
branch
from
4eefc52
to
7c1ae5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes move firewall rule management under
cb networkand deprecate thecb firewallrule command. This comes as part of a request to be able to update firewall rules more completely as described in #161.The following commands are now supported:
cb network add-firewall-rulecb network list-firewall-rulescb network remove-firewall-rulecb network update-firewall-ruleEach command requires the specification of the network to peform the operation. As well, the shell completion logic has been updated to suggest the list of available networks and firewall rule when applicable.