Fix config param valus being truncated. #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur
approved these changes
May 8, 2024
abrightwell
force-pushed
the
abrightwell/fix-config-param-set-truncate
branch
from
23fc03a
to
b1c13b7
Compare
It was reported that the `cb config-param set` command was truncating values that contain a `=` character. This was due to how the input line was being parsed and tokenized. Here, we've simply limited the parsing to the first instance of this character such that it will only ever split the parameter name and value from the input.
abrightwell
force-pushed
the
abrightwell/fix-config-param-set-truncate
branch
from
b1c13b7
to
c2c8d52
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reported that the
cb config-param setcommand was truncating values that contain a=character. This was due to how the input line was being parsed and tokenized. Here, we've simply limited the parsing to the first instance of this character such that it will only ever split the parameter name and value from the input.