Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cb create to require --region with gcp networks. #147

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

abrightwell
Copy link
Member

When creating a cluster in a specific network, there are a few rules that apply that differ between the supported providers.

The execption is specifically with gcp based networks. GCP networks are global meaning they are not bound to a specific region. Therefore it is necessary to specify a region when creating a new cluster of any type with a target network that is gcp based.

All other cases (aws and azr) a provider and region must not be given along with a target network. As this information is attached/bound to the network.

When creating a cluster in a specific network, there are a few rules
that apply that differ between the supported providers.

The execption is specifically with `gcp` based networks. GCP networks
are `global` meaning they are not bound to a specific `region`.
Therefore it is necessary to specify a region when creating a new
cluster of any type with a target network that is `gcp` based.

All other cases (`aws` and `azr`) a provider and region must not be
given along with a target network. As this information is attached/bound
to the network.
@abrightwell abrightwell requested a review from a team as a code owner December 7, 2023 18:30
@abrightwell abrightwell merged commit 74c8d17 into main Dec 7, 2023
2 checks passed
@abrightwell abrightwell deleted the abrightwell/gcp-network-fix branch December 7, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant