[MPDX-7717] Prevent contact details drawer from overlapping task list #768
+9
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canac
added
the
On Staging
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
dr-bizz
requested changes
May 25, 2023
| loading={loading} | ||
| data={data?.tasks.nodes} | ||
| style={{ | ||
| height: `calc(100vh - ${navBarHeight} - ${headerHeight} - ${buttonBarHeight})`, | ||
| width: contactDetailsOpen |
There was a problem hiding this comment.
When on smaller devices you can't select other tasks as they're covered up.
There was a problem hiding this comment.
That's a good point. I just met with Scott in a call, and he said that we should hold off on this until some more design works happens to figure out what to display on smaller screens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shrink the task list when the contact details drawer is open so that all data is still visible.
https://jira.cru.org/browse/MPDX-7717