Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPDX-8129 - new map controls for google maps API #1163

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wjames111
Copy link
Contributor

Description

  • Jira Ticket MPDX-8129
  • This is part 2 for this ticket. The first is an update for @react-google-maps/api to 2.20.3, available here. This PR is for actually testing the new map controls.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@wjames111 wjames111 added On Staging Will be merged to the staging branch by Github Actions Preview Environment Add this label to create an Amplify Preview labels Oct 30, 2024
@wjames111 wjames111 self-assigned this Oct 30, 2024
Copy link

Copy link

Bundle sizes [mpdx-react]

Compared against f442ffa

No significant changes found

@dr-bizz
Copy link
Contributor

dr-bizz commented Oct 31, 2024

Do we want to the new controls to show? Is there a way to hide them? - idk the answer to these questions, but we should ask Scott what he thinks.

@wjames111
Copy link
Contributor Author

Agreed, and I believe we could turn them off with disableDefaultUI property but I think that turns off all controls which I don't think we want. Wondering if there might be some additional options in mapTypeControlOptions once 3.60 is officially out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Staging Will be merged to the staging branch by Github Actions Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants