-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GT-1314, implement saving user count values #826
base: master
Are you sure you want to change the base?
Conversation
I see you added the "On Staging" label, I'll get this merged to the staging branch! |
Merge conflict attempting to merge this into staging. Please fix manually. |
4640b2c
to
fba04d8
Compare
…mobile-content-api into GT-1314-record-counter-values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, rubocop has a couple tiny complaints
Don't merge this yet, I want to wait on merging this until we have a tangible use-case for it. Until then it's fine remaining approved and open. |
db/schema.rb
Outdated
add_foreign_key "attachments", "resources" | ||
add_foreign_key "attributes", "resources" | ||
add_foreign_key "auth_tokens", "access_codes" | ||
add_foreign_key "custom_manifests", "languages" | ||
add_foreign_key "custom_manifests", "resources" | ||
add_foreign_key "custom_pages", "languages" | ||
add_foreign_key "custom_pages", "pages" | ||
add_foreign_key "follow_ups", "destinations" | ||
add_foreign_key "follow_ups", "languages" | ||
add_foreign_key "pages", "resources" | ||
add_foreign_key "resources", "resource_types" | ||
add_foreign_key "resources", "systems" | ||
add_foreign_key "translated_attributes", "attributes" | ||
add_foreign_key "translated_attributes", "translations" | ||
add_foreign_key "translated_pages", "languages" | ||
add_foreign_key "translated_pages", "resources" | ||
add_foreign_key "translations", "languages" | ||
add_foreign_key "translations", "resources" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you dropped all the foreign keys when converting the values to an array field
Merge conflict attempting to merge this into staging. Please fix manually. |
Hmm, maybe not after thinking a bit deeper on possible use cases for the relevant counters going forward. It could be useful to keep track of how often specific languages or specific articles are opened to support future features of "most used languages" or "most read articles" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong review request?
Github says you have to resolve some merge conflicts here.
Yeah, my bad. Wanted #1228 |
No description provided.