[EP-2362] Move footer buttons to user-match-modal #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-bizz
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
It is more complex. It took me some time to wrap my head around. Would you be able yo add more comments explaining how this works. I'm thinking about other devs reviewing this in years to come.
I wasn't able to test it, but the code looks good. I will approve to not block you
src/common/components/userMatchModal/userMatchQuestion/userMatchQuestion.component.js
Show resolved
Hide resolved
src/common/components/userMatchModal/userMatchQuestion/userMatchQuestion.component.spec.js
Outdated
Show resolved
Hide resolved
src/common/components/userMatchModal/userMatchIdentity/userMatchIdentity.component.js
Outdated
Show resolved
Hide resolved
canac
force-pushed
the
2362-okta-user-match-buttons
branch
from
ef5f9a4 to
3948601
Compare
|
@dr-bizz I added additional tests and more comments in the last two commits. Do you feel like those comments explain it well for future devs? |
canac
force-pushed
the
2362-okta-user-match-buttons
branch
from
2d67e08 to
bc4f652
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to move the
.footer-buttonsbuttons outside of the nested child components and into a.modal-footerelement in the DOM that is a sibling of.modal-content. That makes it much easier to style them correctly without relying on hacks like large negative padding to align them with the edges of the modal.We can adjust the buttons' styling if needed. With the work in this PR, that should be much easier now.
Notable changes
I moved the
.modal-bodyclass into each of the modal components instead of having it in theregister-account-modal.I removed the dedicated
failed-verificationstate inregister-account-modal. Now,register-account-modalgoes to the user match state if verification failed, anduser-match-modaldisplays the failed verification state.The logic for the "Next" buttons is more complex now so that the parent can trigger a form submission in the child. I used the same pattern as some checkout components where the parent passes a
submittedprop to the child that is initiallyfalse. The child watches for changes to the prop, and the parent sets it totrueto submit the form.