Revert modal-md size and adjust close button position #1137
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… close button to the left for screen widths between 550-600px
|
@wrandall22 just noticed this hadn't been pulled in but also didn't get reviewed. Is this good? |
|
Can you add Daniel or Caleb C as a reviewer so they can take a look? |
|
@canac added you as a reviewer to this |
|
@rguinee Was there a commit or PR that changed this? And this PR is a reversion back? |
|
Which modals were you trying to improve with this? Unfortunately, the sign in modal looks worse after these changes. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore the modal-md size to 600px and reposition the close button for better accessibility on screens between 550-600px.