-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EP-2470] Enable DD APM Tracing #1075
Conversation
This configures the DD RUM component to send tracing headers in all requests sent to the api url (cortex gateway). This should let us correlate front-end behavior with back-end traces/errors/logs. I am not %100 sure that envServiceProvider can have read() called like this; but I see other envService methods being called on the provider, so I'm guessing it works. I don't have a quick way to test this locally.
Probably left over copy/paste from the rollbar specs.
@dr-bizz would you be up for helping me figure out the right way to get the 'apiUrl' param at config time? I made a guess here, but the unit tests don't like it and I think it's likely that it would break at runtime as well. |
What you've done is correct, let me take a look at the tests. |
This fix will work. |
thanks @dr-bizz ! |
I'll merge (which I believe auto-deploys to prod) in the morning |
Yes, merging does auto-deploy it to production |
Pushing to |
Perhaps this shows traces like we mean to see them? |
Yep, that's what I was hoping to see! |
I wish errors like this one had traces on them. I wonder why they don't. |
Actually, it looks like the traces are attached to the parent action. |
Right. I don't understand, though, why that error doesn't show up in the Errors page. |
Jira
This configures the DD RUM component to send tracing headers in all requests sent to the api url
(cortex gateway). This should let us correlate front-end behavior with back-end traces/errors/logs.