-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dynamic project name before Community Snapshot #2651
base: main
Are you sure you want to change the base?
Conversation
@gaspergrom please review this PR. If it's incorrect, close it with a comment explaining why to help me learn. |
@gaspergrom please review this PR. If it's incorrect, close it with a comment explaining why to help me learn. This PR will be automatically closed in 4 business days if there's no further activity. |
@@ -2,7 +2,7 @@ | |||
<section> | |||
<lf-card class="!bg-gradient-to-b from-primary-25 to-white px-5 pt-5 pb-6"> | |||
<h6 class="text-h6 mb-4"> | |||
Community snapshot | |||
{{ segmentName ? `${segmentName} Community snapshot` : 'Community snapshot' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add it as text above
|
||
const props = defineProps<{ | ||
contributor: Contributor, | ||
}>(); | ||
|
||
const segmentName = computed(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
segments dont have name property use function getSegmentname
Addressing your review. View activity logs for details. |
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@gaspergrom I've addressed your review. Add another review if minor changes are needed. If major changes are needed, retry the issue from the Tusk app with additional context. |
This PR updates the Community Snapshot component in the member profile to include the project segment name dynamically before the "Community Snapshot" text. This change makes it clearer to users that the counts, people list, and other details are project-based and not global.
If a segment name is available, it will be displayed before "Community Snapshot" (e.g., "CNCF Community Snapshot"). If no segment name is available, it will simply display "Community Snapshot".
Tips: