Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primary is set before merging #1754

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Primary is set before merging #1754

merged 3 commits into from
Oct 23, 2023

Conversation

gaspergrom
Copy link
Contributor

@gaspergrom gaspergrom commented Oct 23, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 6b78316

Removed redundant code and added reset logic for the primary property in the components that handle member and organization merge suggestions. This improved the functionality and readability of the member-merge-suggestions-page.vue and organization-merge-suggestions-page.vue files.

🤖 Generated by Copilot at 6b78316

primary reset
merging members and orgs
autumn leaves fall

Why

How

🤖 Generated by Copilot at 6b78316

  • Removed redundant code that set the primary property to 0 in the mounted hook of the MemberMergeSuggestionsPage and OrganizationMergeSuggestionsPage components (link, link)
  • Added code that reset the primary property to 0 in the reset method of the MemberMergeSuggestionsPage and OrganizationMergeSuggestionsPage components (link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@gaspergrom gaspergrom added the Bug Created by Linear-GitHub Sync label Oct 23, 2023
@gaspergrom gaspergrom self-assigned this Oct 23, 2023
@gaspergrom gaspergrom merged commit a4bac6f into main Oct 23, 2023
5 checks passed
@gaspergrom gaspergrom deleted the bugfix/merge-primary branch October 23, 2023 09:56
gaspergrom added a commit that referenced this pull request Oct 23, 2023
(cherry picked from commit a4bac6f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants