Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve lists page performance #1734

Merged
merged 11 commits into from
Oct 24, 2023
Merged

Conversation

joanagmaia
Copy link
Contributor

@joanagmaia joanagmaia commented Oct 19, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 04a3731

Removed unnecessary async and await keywords from member-list-table.vue component and replaced v-loading directive with custom spinner element in several components. These changes improve performance, fix layout issues, and enhance design consistency.

🤖 Generated by Copilot at 04a3731

We're loading data with a spinner, aye
We're loading data with a spinner
We ditched the v-loading for a custom-spinner, aye
Heave away and pull together

Why

How

🤖 Generated by Copilot at 04a3731

  • Add custom spinner element and class for loading state (link, link, link, link, link)
  • Remove unnecessary async and await keywords from onMounted hook (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanagmaia joanagmaia self-assigned this Oct 19, 2023
@joanagmaia joanagmaia merged commit 577cdff into main Oct 24, 2023
4 checks passed
@joanagmaia joanagmaia deleted the improvement/lists-page-performance branch October 24, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants