Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom views #1705

Merged
merged 25 commits into from
Oct 20, 2023
Merged

Custom views #1705

merged 25 commits into from
Oct 20, 2023

Conversation

gaspergrom
Copy link
Contributor

@gaspergrom gaspergrom commented Oct 17, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at aaf0762

This pull request updates the frontend code to use the term config instead of organization or bot for the user's profile settings and the integrations with different services. It also adds the vue-draggable-next package to enable drag and drop functionality in the frontend application. It affects various files in the frontend folder, such as index.html, package.json, package-lock.json, src/i18n/en.js, and several files in the src/integrations, src/modules, and src/components subfolders.

🤖 Generated by Copilot at aaf0762

Oh we're the coders of the frontend crew
And we've got a lot of changes to do
We'll replace organization with config
On the count of three, one, two, three, heave!

Why

How

🤖 Generated by Copilot at aaf0762

  • Replace the term "organization" with "config" in various text and code elements to reflect the new terminology (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Replace the term "filter" with "config" in the query parameters for the routes to the member and organization pages in the dashboard module (link, link, link, link, link, link)
  • Replace the term "bot" with "config" in the text and comment elements for the Slack and Discord integrations (link, link, link, link)
  • Replace the module name all-members with all-contacts and the property name allMembers with allContacts in the dashboard module (link, link)
  • Add the vue-draggable-next package as a dependency for the frontend application and specify its version, URL, hash, and requirements in the package-lock.json file (link, link, link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@gaspergrom gaspergrom added the Feature Created by Linear-GitHub Sync label Oct 17, 2023
@gaspergrom gaspergrom self-assigned this Oct 17, 2023
Copy link
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed 2 more issues:

  1. I noticed that when you refresh in the none default views/tabs, the app doesn't do to the correct tab, it sends you to the All contacts tab.
  2. Also, in the All contacts tab if you add a filter, it shows the Reset View and Save as buttons. But All contacts can't be updated right? Since it's the default view

@gaspergrom gaspergrom merged commit ad2277f into main Oct 20, 2023
5 checks passed
@gaspergrom gaspergrom deleted the feature/custom-views branch October 20, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants