-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom views #1705
Merged
Merged
Custom views #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanagmaia
reviewed
Oct 18, 2023
frontend/src/modules/member/config/saved-views/settings/bot/MemberBotSetting.vue
Outdated
Show resolved
Hide resolved
frontend/src/modules/member/config/saved-views/settings/bot/MemberBotSetting.vue
Outdated
Show resolved
Hide resolved
frontend/src/modules/member/config/saved-views/settings/teamMember/MemberTeamMemberSetting.vue
Outdated
Show resolved
Hide resolved
frontend/src/modules/member/config/saved-views/settings/teamMember/MemberTeamMemberSetting.vue
Outdated
Show resolved
Hide resolved
frontend/src/shared/modules/filters/components/filterTypes/DateFilter.vue
Show resolved
Hide resolved
frontend/src/shared/modules/filters/components/filterTypes/DateFilter.vue
Outdated
Show resolved
Hide resolved
frontend/src/shared/modules/filters/config/constants/date.constants.ts
Outdated
Show resolved
Hide resolved
frontend/src/shared/modules/saved-views/components/forms/SavedViewForm.vue
Show resolved
Hide resolved
joanagmaia
requested changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed 2 more issues:
- I noticed that when you refresh in the none default views/tabs, the app doesn't do to the correct tab, it sends you to the All contacts tab.
- Also, in the All contacts tab if you add a filter, it shows the Reset View and Save as buttons. But All contacts can't be updated right? Since it's the default view
joanagmaia
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at aaf0762
This pull request updates the frontend code to use the term
config
instead oforganization
orbot
for the user's profile settings and the integrations with different services. It also adds thevue-draggable-next
package to enable drag and drop functionality in the frontend application. It affects various files in thefrontend
folder, such asindex.html
,package.json
,package-lock.json
,src/i18n/en.js
, and several files in thesrc/integrations
,src/modules
, andsrc/components
subfolders.
🤖 Generated by Copilot at aaf0762
Why
How
🤖 Generated by Copilot at aaf0762
all-members
withall-contacts
and the property nameallMembers
withallContacts
in the dashboard module (link, link)vue-draggable-next
package as a dependency for the frontend application and specify its version, URL, hash, and requirements in thepackage-lock.json
file (link, link, link, link)Checklist ✅
Feature
,Improvement
, orBug
.