-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crowd linux merge #1648
Merged
Merged
Crowd linux merge #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Gasper Grom <[email protected]>
joanagmaia
approved these changes
Oct 9, 2023
sausage-todd
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at f8716fa
This pull request adds SSO (single sign-on) support to the backend, enhances the analytics materialized view, refactors the activity counting method, fixes some test cases and permission checks, and adds a new Enterprise plan option. It also renames and reverts some database migrations and parameters.
🤖 Generated by Copilot at f8716fa
Why
How
🤖 Generated by Copilot at f8716fa
handleOnboard
method ofAuthService
to expect an object with invitation token and tenant ID as second argument (link)handleOnboard
method inssoCallback
controller (link)id
parameter tosegmentId
in routes forsegmentFind
andsegmentUpdate
controllers (link)segmentId
parameter instead ofid
parameter infindById
andupdate
methods ofSegmentService
(link, link)projectGroupCreate
permission instead ofsegmentCreate
permission insegmentCreateProjectGroup
controller (link)mv_activities_cube
materialized view and create index on organization ID column (link, link)adminSegments
column fromtenantUsers
table to support legacy users and data migration (link, link)adminSegments
property toTenantUser
model and use custom data type for array conversion (link)tenant_plans_type
enum type to addEnterprise
value for new plan option (link)create
,findById
, andupdate
methods ofOrganizationRepository
due to a bug (link, link, link, link)findAndCountAll
method ofOrganizationRepository
to check filtering by activity count and joined at date (link, link)findAll
method instead offindAndCountAll
method ofactivity
model and execute raw SQL query to get activity count infindAndCountAll
method ofActivityRepository
(link, link)U1687886017__addEnterprisePlan.sql
file toU1687261112__addEnterprisePlan.sql
(link)V1687886017__addEnterprisePlan.sql
file (link)Checklist ✅
Feature
,Improvement
, orBug
.