Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crowd linux merge #1648

Merged
merged 41 commits into from
Oct 9, 2023
Merged

Crowd linux merge #1648

merged 41 commits into from
Oct 9, 2023

Conversation

gaspergrom
Copy link
Contributor

@gaspergrom gaspergrom commented Oct 9, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at f8716fa

This pull request adds SSO (single sign-on) support to the backend, enhances the analytics materialized view, refactors the activity counting method, fixes some test cases and permission checks, and adds a new Enterprise plan option. It also renames and reverts some database migrations and parameters.

🤖 Generated by Copilot at f8716fa

SSO config added
handleOnboard modified
Spring cleaning for code

Why

How

🤖 Generated by Copilot at f8716fa

  • Add SSO configuration object and interface to read tenant IDs from environment variables (link, link, link, link, link)
  • Modify handleOnboard method of AuthService to expect an object with invitation token and tenant ID as second argument (link)
  • Pass user's roles from SSO token to handleOnboard method in ssoCallback controller (link)
  • Rename id parameter to segmentId in routes for segmentFind and segmentUpdate controllers (link)
  • Use segmentId parameter instead of id parameter in findById and update methods of SegmentService (link, link)
  • Check projectGroupCreate permission instead of segmentCreate permission in segmentCreateProjectGroup controller (link)
  • Add organization ID, segment ID, and conversation ID columns to mv_activities_cube materialized view and create index on organization ID column (link, link)
  • Drop and add back adminSegments column from tenantUsers table to support legacy users and data migration (link, link)
  • Add adminSegments property to TenantUser model and use custom data type for array conversion (link)
  • Alter tenant_plans_type enum type to add Enterprise value for new plan option (link)
  • Skip failing test cases for create, findById, and update methods of OrganizationRepository due to a bug (link, link, link, link)
  • Add new test cases for findAndCountAll method of OrganizationRepository to check filtering by activity count and joined at date (link, link)
  • Use findAll method instead of findAndCountAll method of activity model and execute raw SQL query to get activity count in findAndCountAll method of ActivityRepository (link, link)
  • Rename U1687886017__addEnterprisePlan.sql file to U1687261112__addEnterprisePlan.sql (link)
  • Delete V1687886017__addEnterprisePlan.sql file (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

garrrikkotua and others added 30 commits October 2, 2023 13:59
@gaspergrom gaspergrom added the Improvement Created by Linear-GitHub Sync label Oct 9, 2023
@gaspergrom gaspergrom self-assigned this Oct 9, 2023
@gaspergrom gaspergrom changed the base branch from main to crowd-linux October 9, 2023 12:47
@sausage-todd sausage-todd merged commit 3e2741f into crowd-linux Oct 9, 2023
9 of 10 checks passed
@sausage-todd sausage-todd deleted the crowd-linux-merge branch October 9, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants