Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invitation signin checking #1644

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Fix invitation signin checking #1644

merged 1 commit into from
Oct 10, 2023

Conversation

gaspergrom
Copy link
Contributor

@gaspergrom gaspergrom commented Oct 9, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 691b2d9

Fixed a bug in the invitation page that caused invitation tokens to be ignored or lost when the user was already signed in. Changed the component lifecycle hook and added a wait action to ensure the authentication state is ready before accepting the invitation.

🤖 Generated by Copilot at 691b2d9

mounted hook used
to fix invitation bug
autumn leaves falling

Why

How

🤖 Generated by Copilot at 691b2d9

  • Fix invitation acceptance bug when user is already signed in (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@gaspergrom gaspergrom added the Bug Created by Linear-GitHub Sync label Oct 9, 2023
@gaspergrom gaspergrom self-assigned this Oct 9, 2023
@gaspergrom gaspergrom merged commit b6e3254 into main Oct 10, 2023
7 checks passed
@gaspergrom gaspergrom deleted the bugfix/invitation-fe branch October 10, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants