-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1596 (Remove Loading Animation) #1626
Conversation
Added validation to the router to prevent showing loading animation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Will deploy it on monday 😄
Just missing to fix the conflicts |
@Sranjan0208 could you just solve the conflicts so that I can merge 😄 ? |
Sorry again @Sranjan0208, was gonna merge this one now but Lint is failing. Can you run the npm run lint to check it out? |
Hey @Sranjan0208, in the root of |
I ran "npm run lint", and made the necessary changes required. Can you check if it's working fine now. Thanks |
Added validation to the router to prevent showing loading animation
Changes proposed ✍️
This pull request addresses the issue of displaying the loading animation even when the user navigates to the same route. To achieve this, I've added a condition to check if the destination route (to.name) is different from the current route (from.name). If they are the same, the loading animation won't be triggered.
What
🤖 Generated by Copilot at ca9b2d6
Fixed a bug where the progress bar would show up when navigating to the same route in the frontend. Updated the logic in
frontend/src/router/index.js
to only start the progress bar when the route name changes.
🤖 Generated by Copilot at ca9b2d6
Why
How
🤖 Generated by Copilot at ca9b2d6
Checklist ✅
Feature
,Improvement
, orBug
.