-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only show a preview of the Headline in Organizations list #1610
Merged
joanagmaia
merged 4 commits into
CrowdDotDev:main
from
jobayer12:improvement/organizations-heading
Oct 9, 2023
Merged
Only show a preview of the Headline in Organizations list #1610
joanagmaia
merged 4 commits into
CrowdDotDev:main
from
jobayer12:improvement/organizations-heading
Oct 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @jobayer12! Thanks for the contribution 😄 |
joanagmaia
requested changes
Oct 3, 2023
frontend/src/modules/organization/components/list/organization-list-table.vue
Outdated
Show resolved
Hide resolved
frontend/src/modules/organization/components/list/organization-list-table.vue
Outdated
Show resolved
Hide resolved
Also, can you run |
@joanagmaia Review my PR again. |
joanagmaia
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Thanks for looking into this 😄
Will merge it on monday
joanagmaia
pushed a commit
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
Improvement #1587
How
🤖 Generated by Copilot at b8b3a42
truncateText
function in the script section oforganization-list-table.vue
that takes a text string, a limit number, and a suffix string and returns the truncated text or the original text if shorter than the limit (link)truncateText
function to thescope.row.headline
orscope.row.description
expression in the table cell template with a limit of 200 and a suffix of '...' (link)Checklist ✅
Feature
,Improvement
, orBug
.