Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show a preview of the Headline in Organizations list #1610

Merged

Conversation

jobayer12
Copy link
Contributor

@jobayer12 jobayer12 commented Oct 3, 2023

Changes proposed ✍️

What

Improvement #1587

How

🤖 Generated by Copilot at b8b3a42

  • Truncate the text displayed in the table cells for organization headline or description to 200 characters using a helper function (link, link)
  • Define the truncateText function in the script section of organization-list-table.vue that takes a text string, a limit number, and a suffix string and returns the truncated text or the original text if shorter than the limit (link)
  • Apply the truncateText function to the scope.row.headline or scope.row.description expression in the table cell template with a limit of 200 and a suffix of '...' (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@CLAassistant
Copy link

CLAassistant commented Oct 3, 2023

CLA assistant check
All committers have signed the CLA.

@joanagmaia
Copy link
Contributor

Hey @jobayer12! Thanks for the contribution 😄
I'll review this one today. Could you sign the CLA in the meantime?

@joanagmaia
Copy link
Contributor

Also, can you run npm run lint on the root of frontend folder?

@jobayer12
Copy link
Contributor Author

@joanagmaia Review my PR again.

Copy link
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
Thanks for looking into this 😄
Will merge it on monday

@joanagmaia joanagmaia merged commit 4847e72 into CrowdDotDev:main Oct 9, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants