Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New onboarding flow #1578

Merged
merged 10 commits into from
Oct 6, 2023
Merged

New onboarding flow #1578

merged 10 commits into from
Oct 6, 2023

Conversation

joanagmaia
Copy link
Contributor

@joanagmaia joanagmaia commented Sep 29, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 6b640ca

This pull request updates the backend and frontend code to support a new onboarding process for tenants, where they can choose whether to go through the process or not, and see more information about the available integrations. It also removes some unused files and code, and fixes some validation issues.

🤖 Generated by Copilot at 6b640ca

tenantCreate changed
Onboarding options added
alert for debug

Why

How

🤖 Generated by Copilot at 6b640ca

  • Add onboardDescription property to all integration config files, to display a short summary of the integration in the onboarding process (link, link, link, link, link, link, link, link, link, link, link, link)
  • Add onboardImage and onboardHighlight properties to github integration config file, to display an image and a flag for the integration in the onboarding process (link)
  • Update useVuelidate hook in all integration connect drawer components, to pass $stopPropagation: true option and prevent validation conflicts in the onboarding process (link, link, link)
  • Update tenantCreate API function to accept onboard property in the payload and remove integrationsRequired property, to indicate whether the tenant wants to go through the onboarding process or not (link)
  • Remove mounted hook in app.vue component, as it is no longer needed to check the ref query parameter and set the onboardType in the local storage (link)
  • Disable no-alert rule in ESLint configuration file, to allow the use of alert for debugging purposes in the frontend code (link)
  • Delete frontend/src/jsons/tenant-community-size.json and frontend/src/jsons/onboard-platforms.json files, as they are no longer used (link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanagmaia joanagmaia added the Improvement Created by Linear-GitHub Sync label Oct 2, 2023
@joanagmaia joanagmaia self-assigned this Oct 2, 2023
frontend/src/integrations/github/config.js Outdated Show resolved Hide resolved
@joanagmaia joanagmaia merged commit b39145c into main Oct 6, 2023
10 checks passed
@joanagmaia joanagmaia deleted the improvement/onboarding-flow branch October 6, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants