Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: redirect people to signup #1561

Merged
merged 2 commits into from
Oct 4, 2023
Merged

chore: redirect people to signup #1561

merged 2 commits into from
Oct 4, 2023

Conversation

a0m0rajab
Copy link
Contributor

@a0m0rajab a0m0rajab commented Sep 26, 2023 •
edited by ghost
Loading

Changes proposed ✍️

What

🤖 Generated by Copilot at f67940c

Redirect unauthenticated users to sign up page when accessing integrations page. This change modifies the isGoingToIntegrationsPage function in auth-guard.js to improve user conversion.
​

🤖 Generated by Copilot at f67940c

To access the integrations page
You need an account at this stage
But if you're not signed in
You won't see a login
You'll be sent to sign up in a rage

Why

close #1149

How

🤖 Generated by Copilot at f67940c

  • Redirect users to sign up page from integrations page if not authenticated (link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanagmaia joanagmaia self-requested a review September 27, 2023 22:03
joanagmaia
joanagmaia approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@joanagmaia joanagmaia merged commit dca6b01 into CrowdDotDev:main Oct 4, 2023
5 checks passed
@a0m0rajab a0m0rajab deleted the singup branch October 4, 2023 15:52
@a0m0rajab
Copy link
Contributor Author

thanks for the merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joanagmaia joanagmaia joanagmaia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[C-1883] Re-direct app.crowd.dev to app.crowd.dev/auth/signup (if user is not logged in)
2 participants
@a0m0rajab @joanagmaia