Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide widget tooltip on quick cursor exit #1530

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

peoray
Copy link
Contributor

@peoray peoray commented Sep 21, 2023

Changes proposed ✍️

What

Fixes #1326

🤖 Generated by Copilot at 797980d

Improve external tooltip handler for report charts. Add a function to hide the tooltip element in frontend/src/modules/report/tooltip.js.

🤖 Generated by Copilot at 797980d

Sing, O Muse, of the skillful coder who devised
A clever way to tame the external tooltip's flight,
That hovering element of cunning and of grace,
That shows the chart's secrets to the curious gaze.

Why

How

🤖 Generated by Copilot at 797980d

  • Add a function to hide the tooltip element after a delay time (link)
  • Call the function after setting the tooltip position and content (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

Copy link
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you able to replicate this?
I tested your work and I wasn't able to replicate it anymore so it looks fixed

@peoray
Copy link
Contributor Author

peoray commented Oct 6, 2023

hey @joanagmaia not sure what you mean. But if you meant, you tested it in my branch, then the PR fixed the issue. I tested it with and without the fix and it worked as expected

@joanagmaia joanagmaia merged commit c7cc7df into CrowdDotDev:main Oct 9, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C-2085] Widget's tooltip gets stuck until refresh or until a new graph is hovered again
2 participants