-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add email option to members identities filter list #1478
base: main
Are you sure you want to change the base?
Conversation
Hey @peoray, if you need any further help on this one let me know 😄 |
@joanagmaia I do. I left a comment on the issue itself :) |
…s-associated-email
…rowd.dev into search-members-associated-email
@joanagmaia how can I make sure Email is added as one of the select options? |
You cannot place email inside identities. You need to treat them almost as separate filters.
|
@joanagmaia to iterate:
I have updated the code with the current work progress, but it still doesn't work as expected. One more thing, for the first option, if multiple options are selected, for example, Twitter and DEV, what's the expected result? |
@joanagmaia Any update on this? Would like to get it over the finish line 🙏🏿 |
Hey @peoray, sorry for the delay! I'll look into the code and your comment and check what's the issue. I'll make an effort to reply to you today |
Hey @peoray, just took a look at your comments and functionality-wise wise it is looking good to me. I'm gonna review the code as well to make sure it is good to go 😄 |
frontend/src/modules/member/config/filters/identities/config.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me 😄 Could you just fix linting?
Hey @peoray, not sure if you missed on my message, but everything looks ok with PR, just missing to fix lint issues. You can run |
@joanagmaia good to go :) |
@joanagmaia what's the status on this :)? |
Changes proposed ✍️
What
Fixes #703
🤖 Generated by Copilot at 57c829d
This pull request adds email filtering and searching to the member module in the frontend. It updates the
identities
filter config and the placeholder text of the main filter infrontend/src/modules/member/config/filters
.
🤖 Generated by Copilot at 57c829d
Why
How
🤖 Generated by Copilot at 57c829d
Checklist ✅
Feature
,Improvement
, orBug
.