increase coverage unit tests, fix grammar naming

CropperBlazor · Oct 22, 2023 · 694c479 · 694c479
1 parent 8e937a0
commit 694c479
Show file tree

Hide file tree

Showing 10 changed files with 171 additions and 101 deletions.
diff --git a/README.md b/README.md
@@ -142,7 +142,7 @@ And then use it in Razor file ([for example](https://github.com/CropperBlazor/Cr
   IsErrorLoadImage="@IsErrorLoadImage"
   OnErrorLoadImageEvent="OnErrorLoadImageEvent"
   Options="Options"
-  IsAvaibleInitCropper="IsAvaibleInitCropper">
+  IsAvailableInitCropper="IsAvailableInitCropper">
 </CropperComponent>
 ```
 

diff --git a/src/Cropper.Blazor/Client/Pages/CropperDemo.razor b/src/Cropper.Blazor/Client/Pages/CropperDemo.razor
@@ -35,7 +35,7 @@
                                       IsErrorLoadImage="@IsErrorLoadImage"
                                       OnErrorLoadImageEvent="OnErrorLoadImageEvent"
                                       Options="Options"
-                                      IsAvaibleInitCropper="IsAvaibleInitCropper" />
+                                      IsAvailableInitCropper="IsAvailableInitCropper" />
                 </div>
             </MudPaper>
         </MudItem>

diff --git a/src/Cropper.Blazor/Client/Pages/CropperDemo.razor.cs b/src/Cropper.Blazor/Client/Pages/CropperDemo.razor.cs
@@ -1,4 +1,6 @@
-using Cropper.Blazor.Client.Components;
+using System.Reflection;
+using System.Text.Json;
+using Cropper.Blazor.Client.Components;
 using Cropper.Blazor.Client.Enums;
 using Cropper.Blazor.Components;
 using Cropper.Blazor.Events;
@@ -14,8 +16,6 @@
 using Microsoft.JSInterop;
 using MudBlazor;
 using MudBlazor.Services;
-using System.Reflection;
-using System.Text.Json;
 using ErrorEventArgs = Microsoft.AspNetCore.Components.Web.ErrorEventArgs;
 
 namespace Cropper.Blazor.Client.Pages
@@ -38,7 +38,7 @@ public partial class CropperDemo : IDisposable
 
         private string Src = "https://fengyuanchen.github.io/cropperjs/v2/picture.jpg";
         private bool IsErrorLoadImage { get; set; } = false;
-        private bool IsAvaibleInitCropper { get; set; } = true;
+        private bool IsAvailableInitCropper { get; set; } = true;
         private readonly string _errorLoadImageSrc = "not-found-image.jpg";
         private Breakpoint Start;
         private Guid SubscriptionId;
@@ -392,7 +392,7 @@ public async Task InputFileChangeAsync(InputFileChangeEventArgs inputFileChangeE
 
                 Src = await CropperComponent!.GetImageUsingStreamingAsync(imageFile, imageFile.Size);
 
-                IsAvaibleInitCropper = true;
+                IsAvailableInitCropper = true;
                 IsErrorLoadImage = false;
 
                 CropperComponent?.Destroy();
@@ -411,12 +411,12 @@ public async Task ReplaceImageAsync(InputFileChangeEventArgs inputFileChangeEven
 
                 if (IsErrorLoadImage)
                 {
-                    IsAvaibleInitCropper = true;
+                    IsAvailableInitCropper = true;
                     IsErrorLoadImage = false;
                 }
                 else
                 {
-                    IsAvaibleInitCropper = false;
+                    IsAvailableInitCropper = false;
                 }
 
                 CropperComponent?.ReplaceAsync(src);

diff --git a/src/Cropper.Blazor/Cropper.Blazor.UnitTests/Components/CropperComponent_Should.cs b/src/Cropper.Blazor/Cropper.Blazor.UnitTests/Components/CropperComponent_Should.cs
@@ -272,8 +272,8 @@ public async Task Should_Render_CropperComponent_SuccessfulAsync()
             ComponentParameter isErrorLoadImageParameter = ComponentParameter.CreateParameter(
                 nameof(CropperComponent.IsErrorLoadImage),
                 false);
-            ComponentParameter isAvaibleInitCropperParameter = ComponentParameter.CreateParameter(
-                nameof(CropperComponent.IsAvaibleInitCropper),
+            ComponentParameter isAvailableInitCropperParameter = ComponentParameter.CreateParameter(
+                nameof(CropperComponent.IsAvailableInitCropper),
                 true);
             ComponentParameter onLoadImageParameter = ComponentParameter.CreateParameter(
                 nameof(CropperComponent.OnLoadImageEvent),
@@ -347,7 +347,7 @@ public async Task Should_Render_CropperComponent_SuccessfulAsync()
                     loadingParameter,
                     errorLoadImageSrcParameter,
                     isErrorLoadImageParameter,
-                    isAvaibleInitCropperParameter,
+                    isAvailableInitCropperParameter,
                     srcParameter,
                     imageClassParameter,
                     onLoadImageParameter,
@@ -597,8 +597,8 @@ public void Should_Not_Render_CropperComponent_With_IsNotAvaibleInitCropper_Para
             ComponentParameter isErrorLoadImage = ComponentParameter.CreateParameter(
                 nameof(CropperComponent.IsErrorLoadImage),
                 true);
-            ComponentParameter isAvaibleInitCropperParameter = ComponentParameter.CreateParameter(
-                nameof(CropperComponent.IsAvaibleInitCropper),
+            ComponentParameter isAvailableInitCropperParameter = ComponentParameter.CreateParameter(
+                nameof(CropperComponent.IsAvailableInitCropper),
                 false);
 
             // act
@@ -608,7 +608,7 @@ public void Should_Not_Render_CropperComponent_With_IsNotAvaibleInitCropper_Para
                     loadingParameter,
                     errorLoadImageSrcParameter,
                     isErrorLoadImage,
-                    isAvaibleInitCropperParameter);
+                    isAvailableInitCropperParameter);
 
             // assert
             IElement expectedElement = cropperComponent.Find($"img.{errorLoadImageClass}");

diff --git a/src/Cropper.Blazor/Cropper.Blazor.UnitTests/Events/CropEndEvent/CropEndEvent_Should.cs b/src/Cropper.Blazor/Cropper.Blazor.UnitTests/Events/CropEndEvent/CropEndEvent_Should.cs
@@ -1,4 +1,5 @@
-using Bogus;
+using System.Collections.Generic;
+using Bogus;
 using Microsoft.JSInterop;
 using Moq;
 using Xunit;
@@ -8,24 +9,37 @@ namespace Cropper.Blazor.UnitTests.Events.CropEndEvent
 {
     public class CropEndEvent_Should
     {
-        private readonly Mock<IJSObjectReference> _mockIJSObjectReference;
-        private readonly Event _event;
+        private static Mock<IJSObjectReference> _mockIJSObjectReference = null!;
 
-        public CropEndEvent_Should()
+        [Theory, MemberData(nameof(TestData_Verify_Dispose))]
+        public void Verify_Dispose(IJSObjectReference? jSObjectReference, Times times)
         {
-            _mockIJSObjectReference = new Mock<IJSObjectReference>();
-            _event = new Faker<Event>()
-                .RuleFor(x => x.OriginalEvent, _mockIJSObjectReference.Object);
-        }
+            // arrange
+            Event @event = new Faker<Event>()
+                .RuleFor(x => x.OriginalEvent, jSObjectReference);
 
-        [Fact]
-        public void Verify_Dispose()
-        {
             // act
-            _event.Dispose();
+            @event.Dispose();
 
             // assert
-            _mockIJSObjectReference.Verify(c => c.DisposeAsync(), Times.Once());
+            _mockIJSObjectReference.Verify(c => c.DisposeAsync(), times);
+        }
+
+        public static IEnumerable<object[]> TestData_Verify_Dispose()
+        {
+            yield return WrapArgs(null, Times.Never());
+
+            _mockIJSObjectReference = new Mock<IJSObjectReference>();
+            yield return WrapArgs(_mockIJSObjectReference.Object, Times.Once());
+
+            static object[] WrapArgs(
+                IJSObjectReference? jSObjectReference,
+                Times times)
+                => new object[]
+                {
+                    jSObjectReference,
+                    times
+                };
         }
     }
 }
diff --git a/src/Cropper.Blazor/Cropper.Blazor.UnitTests/Events/CropMoveEvent/CropMoveEvent_Should.cs b/src/Cropper.Blazor/Cropper.Blazor.UnitTests/Events/CropMoveEvent/CropMoveEvent_Should.cs
@@ -1,4 +1,5 @@
-using Bogus;
+using System.Collections.Generic;
+using Bogus;
 using Microsoft.JSInterop;
 using Moq;
 using Xunit;
@@ -8,24 +9,37 @@ namespace Cropper.Blazor.UnitTests.Events.CropMoveEvent
 {
     public class CropMoveEvent_Should
     {
-        private readonly Mock<IJSObjectReference> _mockIJSObjectReference;
-        private readonly Event _event;
+        private static Mock<IJSObjectReference> _mockIJSObjectReference = null!;
 
-        public CropMoveEvent_Should()
+        [Theory, MemberData(nameof(TestData_Verify_Dispose))]
+        public void Verify_Dispose(IJSObjectReference? jSObjectReference, Times times)
         {
-            _mockIJSObjectReference = new Mock<IJSObjectReference>();
-            _event = new Faker<Event>()
-                .RuleFor(x => x.OriginalEvent, _mockIJSObjectReference.Object);
-        }
+            // arrange
+            Event @event = new Faker<Event>()
+                .RuleFor(x => x.OriginalEvent, jSObjectReference);
 
-        [Fact]
-        public void Verify_Dispose()
-        {
             // act
-            _event.Dispose();
+            @event.Dispose();
 
             // assert
-            _mockIJSObjectReference.Verify(c => c.DisposeAsync(), Times.Once());
+            _mockIJSObjectReference.Verify(c => c.DisposeAsync(), times);
+        }
+
+        public static IEnumerable<object[]> TestData_Verify_Dispose()
+        {
+            yield return WrapArgs(null, Times.Never());
+
+            _mockIJSObjectReference = new Mock<IJSObjectReference>();
+            yield return WrapArgs(_mockIJSObjectReference.Object, Times.Once());
+
+            static object[] WrapArgs(
+                IJSObjectReference? jSObjectReference,
+                Times times)
+                => new object[]
+                {
+                    jSObjectReference,
+                    times
+                };
         }
     }
 }
diff --git a/src/Cropper.Blazor/Cropper.Blazor.UnitTests/Events/CropStartEvent/CropStartEvent_Should.cs b/src/Cropper.Blazor/Cropper.Blazor.UnitTests/Events/CropStartEvent/CropStartEvent_Should.cs
@@ -1,4 +1,5 @@
-using Bogus;
+using System.Collections.Generic;
+using Bogus;
 using Microsoft.JSInterop;
 using Moq;
 using Xunit;
@@ -8,24 +9,37 @@ namespace Cropper.Blazor.UnitTests.Events.CropStartEvent
 {
     public class CropStartEvent_Should
     {
-        private readonly Mock<IJSObjectReference> _mockIJSObjectReference;
-        private readonly Event _event;
+        private static Mock<IJSObjectReference> _mockIJSObjectReference = null!;
 
-        public CropStartEvent_Should()
+        [Theory, MemberData(nameof(TestData_Verify_Dispose))]
+        public void Verify_Dispose(IJSObjectReference? jSObjectReference, Times times)
         {
-            _mockIJSObjectReference = new Mock<IJSObjectReference>();
-            _event = new Faker<Event>()
-                .RuleFor(x => x.OriginalEvent, _mockIJSObjectReference.Object);
-        }
+            // arrange
+            Event @event = new Faker<Event>()
+                .RuleFor(x => x.OriginalEvent, jSObjectReference);
 
-        [Fact]
-        public void Verify_Dispose()
-        {
             // act
-            _event.Dispose();
+            @event.Dispose();
 
             // assert
-            _mockIJSObjectReference.Verify(c => c.DisposeAsync(), Times.Once());
+            _mockIJSObjectReference.Verify(c => c.DisposeAsync(), times);
+        }
+
+        public static IEnumerable<object[]> TestData_Verify_Dispose()
+        {
+            yield return WrapArgs(null, Times.Never());
+
+            _mockIJSObjectReference = new Mock<IJSObjectReference>();
+            yield return WrapArgs(_mockIJSObjectReference.Object, Times.Once());
+
+            static object[] WrapArgs(
+                IJSObjectReference? jSObjectReference,
+                Times times)
+                => new object[]
+                {
+                    jSObjectReference,
+                    times
+                };
         }
     }
 }
diff --git a/src/Cropper.Blazor/Cropper.Blazor.UnitTests/Events/ZoomEvent/ZoomEvent_Should.cs b/src/Cropper.Blazor/Cropper.Blazor.UnitTests/Events/ZoomEvent/ZoomEvent_Should.cs
@@ -1,4 +1,5 @@
-using Bogus;
+using System.Collections.Generic;
+using Bogus;
 using Microsoft.JSInterop;
 using Moq;
 using Xunit;
@@ -8,24 +9,37 @@ namespace Cropper.Blazor.UnitTests.Events.ZoomEvent
 {
     public class ZoomEvent_Should
     {
-        private readonly Mock<IJSObjectReference> _mockIJSObjectReference;
-        private readonly Event _event;
+        private static Mock<IJSObjectReference> _mockIJSObjectReference = null!;
 
-        public ZoomEvent_Should()
+        [Theory, MemberData(nameof(TestData_Verify_Dispose))]
+        public void Verify_Dispose(IJSObjectReference? jSObjectReference, Times times)
         {
-            _mockIJSObjectReference = new Mock<IJSObjectReference>();
-            _event = new Faker<Event>()
-                .RuleFor(x => x.OriginalEvent, _mockIJSObjectReference.Object);
-        }
+            // arrange
+            Event @event = new Faker<Event>()
+                .RuleFor(x => x.OriginalEvent, jSObjectReference);
 
-        [Fact]
-        public void Verify_Dispose()
-        {
             // act
-            _event.Dispose();
+            @event.Dispose();
 
             // assert
-            _mockIJSObjectReference.Verify(c => c.DisposeAsync(), Times.Once());
+            _mockIJSObjectReference.Verify(c => c.DisposeAsync(), times);
+        }
+
+        public static IEnumerable<object[]> TestData_Verify_Dispose()
+        {
+            yield return WrapArgs(null, Times.Never());
+
+            _mockIJSObjectReference = new Mock<IJSObjectReference>();
+            yield return WrapArgs(_mockIJSObjectReference.Object, Times.Once());
+
+            static object[] WrapArgs(
+                IJSObjectReference? jSObjectReference,
+                Times times)
+                => new object[]
+                {
+                    jSObjectReference,
+                    times
+                };
         }
     }
 }
diff --git a/src/Cropper.Blazor/Cropper.Blazor.UnitTests/Models/CroppedCanvas_Should.cs b/src/Cropper.Blazor/Cropper.Blazor.UnitTests/Models/CroppedCanvas_Should.cs
@@ -1,4 +1,5 @@
-using Bogus;
+using System.Collections.Generic;
+using Bogus;
 using Cropper.Blazor.Models;
 using Microsoft.JSInterop;
 using Moq;
@@ -8,24 +9,37 @@ namespace Cropper.Blazor.UnitTests.Models
 {
     public class CroppedCanvas_Should
     {
-        private readonly Mock<IJSObjectReference> _mockIJSObjectReference;
-        private readonly CroppedCanvas _croppedCanvas;
+        private static Mock<IJSObjectReference> _mockIJSObjectReference = null!;
 
-        public CroppedCanvas_Should()
+        [Theory, MemberData(nameof(TestData_Verify_Dispose))]
+        public void Verify_Dispose(IJSObjectReference? jSObjectReference, Times times)
         {
-            _mockIJSObjectReference = new Mock<IJSObjectReference>();
-            _croppedCanvas = new Faker<CroppedCanvas>()
-                .CustomInstantiator(f => new CroppedCanvas(_mockIJSObjectReference.Object));
-        }
+            // arrange
+            CroppedCanvas croppedCanvas = new Faker<CroppedCanvas>()
+                .CustomInstantiator(f => new CroppedCanvas(jSObjectReference));
 
-        [Fact]
-        public void Verify_Dispose()
-        {
             // act
-            _croppedCanvas.Dispose();
+            croppedCanvas.Dispose();
 
             // assert
-            _mockIJSObjectReference.Verify(c => c.DisposeAsync(), Times.Once());
+            _mockIJSObjectReference.Verify(c => c.DisposeAsync(), times);
+        }
+
+        public static IEnumerable<object[]> TestData_Verify_Dispose()
+        {
+            yield return WrapArgs(null, Times.Never());
+
+            _mockIJSObjectReference = new Mock<IJSObjectReference>();
+            yield return WrapArgs(_mockIJSObjectReference.Object, Times.Once());
+
+            static object[] WrapArgs(
+                IJSObjectReference? jSObjectReference,
+                Times times)
+                => new object[]
+                {
+                    jSObjectReference,
+                    times
+                };
         }
     }
 }