Array Support #422
Open
Array Support #422
+44
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arifBurakDemiray
approved these changes
Nov 5, 2024
Validators.js
Outdated
| L.w(`${functionName}, segmentation value: [${value}] for the key: [${key}] must contain only strings, numbers, or booleans in the array!`); | ||
| return false; | ||
| } | ||
| } else if (value && valueType !== "string" && valueType !== "number" && valueType !== "boolean") { |
There was a problem hiding this comment.
you might maybe do same typeof check as above, but it is fine
you rock 🚀
There was a problem hiding this comment.
i'd break my head instead of breaking your heart :D updated it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.