feat: set_id method for the node #109
Open
+157
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AliRKat you gotta lint this |
AliRKat
reviewed
Nov 4, 2024
There was a problem hiding this comment.
Cool work but this would also require adding tests, would you like me to add few at least for sanity checks? @arifBurakDemiray
|
@AliRKat You are best. I have also added DeviceIdType enums. Well, if you would like to add tests, I really appreciate it. 😅. However, let me try to add some, if I cannot make it, I will let you know. |
AliRKat
approved these changes
Nov 5, 2024
turtledreams
requested changes
Nov 6, 2024
| * @param {string} newId - new user/device ID to use. Must be a non-empty string value. Invalid values (like null, empty string or undefined) will be rejected | ||
| * */ | ||
| Countly.set_id = function(newId) { | ||
| cc.log(cc.logLevelEnums.INFO, `set_id, Changing the device ID to: [${newId}]`); |
There was a problem hiding this comment.
lets add type check here also
There was a problem hiding this comment.
which type check? should we move it to the upper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.