Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a patch #2959

Closed
wants to merge 1 commit into from
Closed

Fixing a patch #2959

wants to merge 1 commit into from

Conversation

PratyushKing
Copy link
Contributor

There was a recent commit by @valentinbreiz, that commit changed the copy paths of IL2CPU artifacts from Debug to Release which is not working as of right now on any current linux device and this pull request will revert it back to when it worked, This makes sure that there are no errors during the general build process.

@9xbt
Copy link
Contributor

9xbt commented Feb 21, 2024

I would discard any changes to any .lock.json file before making the PR and I would also add an option to switch between debug and release instead of undoing the changes to a coredev

@PratyushKing
Copy link
Contributor Author

I would discard any changes to any .lock.json file before making the PR and I would also add an option to switch between debug and release instead of undoing the changes to a coredev

Well, I wasn't sure about it either so I have enabled to allow edits according to coredevs so its entirely modifyable

@selkij
Copy link
Contributor

selkij commented Feb 21, 2024

Already done in #2897
I will finish this when I have time in the week

@9xbt
Copy link
Contributor

9xbt commented Feb 21, 2024

LMFAO

@selkij
Copy link
Contributor

selkij commented Feb 21, 2024

consider this PR useless also you should continue your minecraft gameplay it was so interesting and also the python tutorial damn your voice makes me wanna eat spicy strawberries

@selkij
Copy link
Contributor

selkij commented Feb 21, 2024

and also we don't use Debug but Release so it's even more useless

@zarlo
Copy link
Member

zarlo commented Feb 21, 2024

okay this is some thing that keeps breaking i thing we should just set the out put paths just to be done with it

@PratyushKing
Copy link
Contributor Author

consider this PR useless also you should continue your minecraft gameplay it was so interesting and also the python tutorial damn your voice makes me wanna eat spicy strawberries

there was no voice.....

@PratyushKing
Copy link
Contributor Author

also yeah ill just keep it closed until theres something fixed, i anyways just update my own repo for changes and use fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants