Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DHCP improvements + TCP fix #2808

Merged
merged 13 commits into from
Nov 6, 2023
Merged

Conversation

valentinbreiz
Copy link
Member

No description provided.

@valentinbreiz valentinbreiz mentioned this pull request Oct 31, 2023
@valentinbreiz valentinbreiz changed the title ✅ Add DHCP + TCP connections unit tests DHCP improvements + TCP fix Nov 2, 2023
@valentinbreiz
Copy link
Member Author

valentinbreiz commented Nov 2, 2023

@quajak vmware is not supported on our VPS' CPU :(
I need it to test the network stack, bochs is too tricky
Should we merge this and temporarily disable network tests? (it contains TCP and DHCP fix in addition to tests)

@quajak
Copy link
Member

quajak commented Nov 2, 2023

Sounds good to me. A bit unfortunate but disabling the network tests seems reasonable.

@valentinbreiz valentinbreiz merged commit a78f61d into master Nov 6, 2023
3 checks passed
@valentinbreiz valentinbreiz deleted the feature/networkConnectionTests branch November 6, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants