Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Update MCCD version #615

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tobias-liaudat
Copy link
Member

@tobias-liaudat tobias-liaudat commented Feb 17, 2023

This minor fix solves the bug generated by the new ModOpt version in MCCD.

Solves #601
Closes #601

Summary

Developers should provide a summary of the proposed changes here and include "closes #" if this addresses an open issue.

Reviewer Checklist

Reviewers should tick the following boxes before approving and merging the PR.

  • The PR targets the develop branch
  • The PR is assigned to the developer
  • The PR has appropriate labels
  • The PR is included in appropriate projects and/or milestones
  • The PR includes a clear description of the proposed changes
  • If the PR addresses an open issue the description includes "closes #"
  • The code and documentation style match the current standards
  • Documentation has been added/updated consistently with the code
  • All CI tests are passing
  • API docs have been built and checked at least once (if relevant)
  • All changed files have been checked and comments provided to the developer
  • All of the reviewer's comments have been satisfactorily addressed by the developer

This minor fix solves the bug generated by the new ModOpt version in MCCD.

Solves #601 
Closes #601
@sfarrens
Copy link
Member

Hey @tobias-liaudat, I recently merged a PR in PySAP that fixes the library issues for macOS. I have not tagged a new release yet as I need to tag a new release of Sparse2D first and there are a couple issues I need to investigate first. I am hoping to have this all resolved this week. I would propose that you tag new version of MCCD based on the new PySAP release for this PR before we merge. This should resolve most (if not all) the CI issues.

@tobias-liaudat
Copy link
Member Author

Hi @sfarrens
Ah yes, please ping me when these releases are done and I'll proceed to tag a new MCCD version with the new releases.

@sfarrens
Copy link
Member

One thing you could do now is make sure that MCCD works with the PySAP develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] MCCD / modopt missing attribute
2 participants