Small fixes for expected context transformer model #211
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes small fixes to the Expected Context Transformer Model to account for changes in numpy and sklearn dependencies.
normalize
to ensure we are passing in numpy array and not numpy matrix since use ofnormalize
and other linear algebra operations for matrices are being deprecated here.allow_pickle
field to True when loading Expected Context saved files since they contain objects. This field is now default to False as of numpy version 1.16.3 here.How has this been tested?
Manually.
Other information
Note the change in
np.load
may affect loading of other models if they save pickled data.