Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes for expected context transformer model #211

Merged
merged 3 commits into from
May 18, 2024

Conversation

vianxnguyen
Copy link
Contributor

Description

This PR includes small fixes to the Expected Context Transformer Model to account for changes in numpy and sklearn dependencies.

  1. Change use of sklearn normalize to ensure we are passing in numpy array and not numpy matrix since use of normalize and other linear algebra operations for matrices are being deprecated here.
  2. Set allow_pickle field to True when loading Expected Context saved files since they contain objects. This field is now default to False as of numpy version 1.16.3 here.

How has this been tested?

Manually.

Other information

Note the change in np.load may affect loading of other models if they save pickled data.

@seanzhangkx8
Copy link
Collaborator

KC and I tested locally with notebook, worked with older version of scipy. Will file an issue later about newer version scipy related issue. Thank you Vivian! Will merge now.

@seanzhangkx8 seanzhangkx8 merged commit 7410b8f into CornellNLP:master May 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants