Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove genesis templates #433

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Remove genesis templates #433

merged 1 commit into from
Sep 23, 2024

Conversation

masihyeganeh
Copy link
Contributor

@masihyeganeh masihyeganeh commented Sep 20, 2024 •
edited by CoreumDevelopment
Loading

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@masihyeganeh masihyeganeh requested a review from a team as a code owner September 20, 2024 11:33
@masihyeganeh masihyeganeh requested review from dzmitryhil, miladz68 and ysv and removed request for a team September 20, 2024 11:33
dzmitryhil
dzmitryhil approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @miladz68 and @ysv)

miladz68
miladz68 approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

@masihyeganeh masihyeganeh merged commit 203a61a into master Sep 23, 2024
3 checks passed
@masihyeganeh masihyeganeh deleted the masih/remove-genesis-templates branch September 23, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miladz68 miladz68 miladz68 approved these changes

@dzmitryhil dzmitryhil dzmitryhil approved these changes

@ysv ysv Awaiting requested review from ysv ysv is a code owner automatically assigned from CoreumFoundation/team-blockchain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@masihyeganeh @dzmitryhil @miladz68