Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hermes config template to reflect changes to 1.6 #276

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

miladz68
Copy link
Contributor

@miladz68 miladz68 commented Aug 24, 2023

Description

we have update hermes to 1.6, which requires some changes in the config structure. This PR, fixes the template so the relayer can start normally.

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@miladz68 miladz68 requested a review from a team as a code owner August 24, 2023 10:51
@miladz68 miladz68 requested review from dzmitryhil, vertex451, ysv and wojtek-coreum and removed request for a team August 24, 2023 10:51
Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil, @vertex451, and @wojtek-coreum)

Copy link
Collaborator

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil and @vertex451)

@miladz68 miladz68 merged commit 2514bc5 into v0.47-migration-v2 Aug 24, 2023
4 checks passed
@miladz68 miladz68 deleted the milad/fix-hermes-config-template branch August 24, 2023 12:48
miladz68 added a commit that referenced this pull request Aug 29, 2023
* Fixe hermes config template to reflect 1.6 changes

* Merge branch 'v0.47-migration-v2' into milad/fix-hermes-config-template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants