Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRPC client codec fix #270

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Conversation

dzmitryhil
Copy link
Contributor

@dzmitryhil dzmitryhil commented Aug 11, 2023

Description

Set correc codec for the GRPC client.

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@dzmitryhil dzmitryhil requested a review from a team as a code owner August 11, 2023 11:25
@dzmitryhil dzmitryhil requested review from vertex451, miladz68, ysv and wojtek-coreum and removed request for a team August 11, 2023 11:25
Copy link
Collaborator

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @miladz68, @vertex451, and @ysv)


infra/cosmoschain/base.go line 194 at r1 (raw file):

}

func dialGRPCClient(url string, mm module.BasicManager) (*grpc.ClientConn, error) {

Let's export it here and reuse in cored

miladz68
miladz68 previously approved these changes Aug 15, 2023
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @vertex451, and @ysv)

@ysv ysv requested a review from wojtek-coreum August 15, 2023 10:37
Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @vertex451 and @wojtek-coreum)


infra/cosmoschain/base.go line 194 at r1 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

Let's export it here and reuse in cored

I 100% agree wit this approach
@wojtek-coreum could you pls take care of this PR & finalize pls ?

Copy link
Collaborator

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil and @vertex451)

Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @vertex451)

@ysv ysv merged commit da497d0 into v0.47-migration-v2 Aug 16, 2023
4 checks passed
@ysv ysv deleted the dzmitryhil/grpc-client-codec-fix branch August 16, 2023 09:12
miladz68 pushed a commit that referenced this pull request Aug 29, 2023
* * Fix GRPC client codec usage.

* Merge v0.47-migration-v2 into dzmitryhil/grpc-client-codec-fix

* deduplicate code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants