Update v0.47 migration to v2 compatible

[dzmitryhil]

Description

The PR contains changes required for the crust to run tests for the coreum v0.47-migration-v2 branch.

Reviewers checklist:

• Try to write more meaningful comments with clear actions to be taken.
• Nit-picking should be unblocking. Focus on core issues.

Authors checklist

• Provide a concise and meaningful description
• Review the code yourself first, before making the PR.
• Annotate your PR in places that require explanation.
• Think and try to split the PR to smaller PR if it is big.

---

This change is 

[wojtek-coreum]

Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dzmitryhil, @miladz68, @vertex451, and @ysv)

---

infra/apps/cored/cored.go line 222 at r1 (raw file):

		WithChainID(string(c.config.NetworkConfig.ChainID())).
		WithRPCClient(rpcClient).
		WithGRPCClient(grpcClient).

Why GRPC is removed? It is required for the health check. Otherwise RPC might be up but GRPC not (yet) and integration tests might fail

---

infra/apps/cored/cored.go line 223 at r1 (raw file):

		WithRPCClient(rpcClient).
		WithGRPCClient(grpcClient).
		WithKeyring(keyring.NewInMemory()).

why removed?

---

infra/apps/cored/cored.go line 285 at r1 (raw file):

				"--inv-check-period", "1",
				"--chain-id", string(c.config.NetworkConfig.ChainID()),
				"--minimum-gas-prices", fmt.Sprintf("0.000000000000000001%s", c.config.NetworkConfig.Denom()),

Ive seen in the cored PR that you set it there internally, so why is it needed to do it here?

[ysv]

Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dzmitryhil, @miladz68, @vertex451, and @wojtek-coreum)

---

infra/apps/cored/cored.go line 222 at r1 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

Why GRPC is removed? It is required for the health check. Otherwise RPC might be up but GRPC not (yet) and integration tests might fail

I think Dima explain this during the call
But I though that temporary fix is different there (not to use GRPC in integration tests).

As for removing it in healthchecks I'm not sure

---

infra/apps/cored/cored.go line 285 at r1 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

Ive seen in the cored PR that you set it there internally, so why is it needed to do it here?

Same question

[dzmitryhil]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @miladz68, @vertex451, @wojtek-coreum, and @ysv)

---

infra/apps/cored/cored.go line 222 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

I think Dima explain this during the call
But I though that temporary fix is different there (not to use GRPC in integration tests).

As for removing it in healthchecks I'm not sure

Right. And also we don't need to init both GRPC and RPC because only one works.

---

infra/apps/cored/cored.go line 223 at r1 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

why removed?

See prev comment.

---

infra/apps/cored/cored.go line 285 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

Same question

We ignore in the crust the standard init, and form the config ourselves

[ysv]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @miladz68, @vertex451, and @wojtek-coreum)

---

infra/apps/cored/cored.go line 222 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

Right. And also we don't need to init both GRPC and RPC because only one works.

yes we don't need both
But in znet we want to make sure both are up in healthchecks, no ?

[wojtek-coreum]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dzmitryhil, @miladz68, and @vertex451)

---

infra/apps/cored/cored.go line 223 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

See prev comment.

but this question is about keyring

[dzmitryhil]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @miladz68, @vertex451, @wojtek-coreum, and @ysv)

---

infra/apps/cored/cored.go line 222 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

yes we don't need both
But in znet we want to make sure both are up in healthchecks, no ?

No, we need to check that znet is running. Also you you set both, only GRPC is used.

---

infra/apps/cored/cored.go line 223 at r1 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

but this question is about keyring

I didn't get it. The keyring is removed since it isn't used for the client.

[wojtek-coreum]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @miladz68, @vertex451, and @ysv)

---

infra/apps/cored/cored.go line 222 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

No, we need to check that znet is running. Also you you set both, only GRPC is used.

so our integration tests don't use grpc again?

[dzmitryhil]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @miladz68, @vertex451, @wojtek-coreum, and @ysv)

---

infra/apps/cored/cored.go line 222 at r1 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

so our integration tests don't use grpc again?

Yes and we have a task to recover it, I explained it today.

[miladz68]

Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @vertex451, @wojtek-coreum, and @ysv)

[miladz68]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @vertex451, @wojtek-coreum, and @ysv)

[dzmitryhil]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @vertex451, @wojtek-coreum, and @ysv)

---

infra/apps/cored/cored.go line 222 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

Yes and we have a task to recover it, I explained it today.

Fixed.

[wojtek-coreum]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @vertex451 and @ysv)

[ysv]

Reviewed 1 of 3 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @vertex451)