-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hermes version to v1.6.0 and config close to mainnet. #257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dzmitryhil, @vertex451, @wojtek-coreum, and @ysv)
infra/apps/hermes/config.tmpl
line 33 at r1 (raw file):
# Whether or not to enable the connection workers for handshake completion. [Required] enabled = true
I don't think we need to enable this. same goes for channels, we do the handshakes once and specifically trigger the handshakes.
infra/apps/hermes/config.tmpl
line 39 at r1 (raw file):
# Whether or not to enable the channel workers for handshake completion. [Required] enabled = true
commented above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @miladz68, @vertex451, @wojtek-coreum, and @ysv)
infra/apps/hermes/config.tmpl
line 33 at r1 (raw file):
Previously, miladz68 (milad) wrote…
I don't think we need to enable this. same goes for channels, we do the handshakes once and specifically trigger the handshakes.
Done.
infra/apps/hermes/config.tmpl
line 39 at r1 (raw file):
Previously, miladz68 (milad) wrote…
commented above.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @miladz68, @vertex451, and @wojtek-coreum)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @vertex451 and @wojtek-coreum)
This change is