Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hermes version to v1.6.0 and config close to mainnet. #257

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

dzmitryhil
Copy link
Contributor

@dzmitryhil dzmitryhil commented Aug 1, 2023

This change is Reviewable

@dzmitryhil dzmitryhil requested a review from a team as a code owner August 1, 2023 12:19
@dzmitryhil dzmitryhil requested review from vertex451, miladz68, ysv and wojtek-coreum and removed request for a team August 1, 2023 12:19
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dzmitryhil, @vertex451, @wojtek-coreum, and @ysv)


infra/apps/hermes/config.tmpl line 33 at r1 (raw file):


# Whether or not to enable the connection workers for handshake completion. [Required]
enabled = true

I don't think we need to enable this. same goes for channels, we do the handshakes once and specifically trigger the handshakes.


infra/apps/hermes/config.tmpl line 39 at r1 (raw file):


# Whether or not to enable the channel workers for handshake completion. [Required]
enabled = true

commented above.

Copy link
Contributor Author

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @miladz68, @vertex451, @wojtek-coreum, and @ysv)


infra/apps/hermes/config.tmpl line 33 at r1 (raw file):

Previously, miladz68 (milad) wrote…

I don't think we need to enable this. same goes for channels, we do the handshakes once and specifically trigger the handshakes.

Done.


infra/apps/hermes/config.tmpl line 39 at r1 (raw file):

Previously, miladz68 (milad) wrote…

commented above.

Done.

@ysv ysv requested a review from miladz68 August 2, 2023 12:25
Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @miladz68, @vertex451, and @wojtek-coreum)

Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @vertex451 and @wojtek-coreum)

@dzmitryhil dzmitryhil merged commit 22df2e9 into master Aug 2, 2023
6 checks passed
@dzmitryhil dzmitryhil deleted the dzmitryhil/hermes-reconfiguration branch August 2, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants