Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add some more features to when_touching and some fixes #44

Merged
merged 3 commits into from
Dec 8, 2024
Merged

fix: add some more features to when_touching and some fixes #44

merged 3 commits into from
Dec 8, 2024

Conversation

koen1711
Copy link
Collaborator

@koen1711 koen1711 commented Dec 7, 2024

No description provided.

@koen1711 koen1711 requested a review from a team as a code owner December 7, 2024 18:41
@koen1711 koen1711 requested a review from boutreet December 7, 2024 18:41
@koen1711 koen1711 linked an issue Dec 7, 2024 that may be closed by this pull request
[enhancement] a when_stopped_touching event and when_touching_wall and when_stopped_touching_wall #29
Closed
MartenPostma
MartenPostma approved these changes Dec 8, 2024
View reviewed changes
Copy link

@MartenPostma MartenPostma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

click release: fixed 👍
new_image.image can now load image from path 👍
play.when_touching now works for multiple objects 👍
sound -> first sprite which needs .play() to work 👍
afbeelding.size now works 👍

@koen1711 koen1711 merged commit db43e33 into master Dec 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartenPostma MartenPostma MartenPostma approved these changes

@boutreet boutreet Awaiting requested review from boutreet boutreet is a code owner automatically assigned from Corderius-College-Amersfoort/play-code-owners

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[enhancement] a when_stopped_touching event and when_touching_wall and when_stopped_touching_wall
2 participants
@koen1711 @MartenPostma