Support python 3.9 #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
=======================================
Coverage 96.30% 96.30%
=======================================
Files 7 7
Lines 325 325
=======================================
Hits 313 313
Misses 12 12
Continue to review full report at Codecov.
|
|
Thanks! The upper version pins come from an abundance of caution. There were some breaking changes in the last few minor python versions. Anyway, I'll appove and merge this. The next release will drop Py 3.5 so don't worry that the tests fail. |
AlbertDeFusco
approved these changes
Dec 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I did not see #26 before opening this PR, feel free to close mine!)
I attempted to install
tranquilizerwith pip in a Python 3.9 environment and ended up with a few horrific error messages and pip installing the version0.0.5😄I've bumped the pins to support Python 3.9 and ran the test suite successfully in a conda env with the packages pulled from
defaults. Tried Python 3.10 too but all the dependencies are not yet available ondefaults(they must be on conda-forge thought, and pypi). Out of curiosity, what's the reason for pinning the upper Python version supported?This PR also contains a few changes that remove warnings emitted during the test suite execution, and make a few minor changes to the README.