IsValid card options (#130)

* feat: adding cards options to isValid method * chore: additional tests and info in README * fix: validating unsupported cards correctly * chore: additional unsupported cards tests Co-authored-by: Ciro Ferreira da Cruz <[email protected]>
ContaAzul · Feb 26, 2021 · ce71b4f · ce71b4f
1 parent 1fe2331
commit ce71b4f
Show file tree

Hide file tree

Showing 3 changed files with 99 additions and 11 deletions.
diff --git a/README.md b/README.md
@@ -28,11 +28,11 @@ $ npm install creditcard.js
 ## Usage
 
 ```javascript
-import { 
-  isValid, 
-  isExpirationDateValid, 
-  isSecurityCodeValid, 
-  getCreditCardNameByNumber 
+import {
+  isValid,
+  isExpirationDateValid,
+  isSecurityCodeValid,
+  getCreditCardNameByNumber,
 } from 'creditcard.js';
 
 isValid('4916108926268679'); // returns true
@@ -52,7 +52,13 @@ Checks whether the credit card number format is valid. _(See the full list of [c
 _Required_\
 Type: `string`
 
------
+**options**
+
+_Optional_\
+Type: `{ cards: string[] } `
+
+---
+
 ### `isExpirationDateValid(month, year)` -> `boolean`
 
 Checks that the expiration date is valid and not expired. _(2 or 4 digit years are accepted)_
@@ -67,7 +73,7 @@ Type: `string`
 _Required_\
 Type: `string`
 
------
+---
 
 ### `isSecurityCodeValid(creditCardNumber, securityCode)` -> `boolean`
 
@@ -83,7 +89,7 @@ Type: `string`
 _Required_\
 Type: `string`
 
------
+---
 
 ### `getCreditCardNameByNumber(number)` -> `string`
 
@@ -94,7 +100,7 @@ Returns the credit card type from the card number. _(See the full list of [curre
 _Required_\
 Type: `string`
 
------
+---
 
 ## Suportted credit card types
 

diff --git a/src/creditcard.js b/src/creditcard.js
@@ -20,15 +20,33 @@ export const isExpirationDateValid = (month, year) => {
   );
 };
 
-export const isValid = (number) => {
+export const isValid = (number, options = {}) => {
   const invalidDigits = new RegExp('[^0-9- ]');
+  const { cards } = options;
 
   if (invalidDigits.test(number)) return false;
 
   const sum = sumNumber(number.replace(/\D/g, ''));
-  return sum > 0 && sum % 10 === 0;
+  const sumIsOk = sum > 0 && sum % 10 === 0;
+
+  if (cards && cards.length) {
+    return (
+      sumIsOk &&
+      areCardsSupported(cards) &&
+      cards
+        .map((c) => c.toLowerCase())
+        .includes(getCreditCardNameByNumber(number).toLowerCase())
+    );
+  }
+
+  return sumIsOk;
 };
 
+function areCardsSupported(passedCards) {
+  const supportedCards = CARDS.map((c) => c.name.toLowerCase());
+  return passedCards.every((c) => supportedCards.includes(c.toLowerCase()));
+}
+
 function findCreditCardObjectByNumber(number) {
   if (!number) return {};
   const numberOnly = number.replace(/[^\d]/g, '');