-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CSL-3352] Enforce HTTPS on ServiceUrl #193
[CSL-3352] Enforce HTTPS on ServiceUrl #193
Conversation
@@ -247,6 +248,32 @@ describe('ConstructorIO - Utils - Helpers', () => { | |||
it('Should prefer local method headers when both global and local method options headers are defined', () => { | |||
expect(combineCustomHeaders(globalOptions, methodOptions)).to.deep.equal(methodOptions.headers); | |||
}); | |||
|
|||
it('Should return the url without any modification', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like these tests are under the describe statement of another function (describe('combineCustomHeaders'...
). Can we move them to a describe statement of their own?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sure! Sorry about that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @HFaifman I added one additional test but the rest looks good. Thanks for working on this
No description provided.