[CSL-3352] Enforce HTTPS on ServiceUrl #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esezen
reviewed
Mar 29, 2024
| @@ -247,6 +248,32 @@ describe('ConstructorIO - Utils - Helpers', () => { | |||
| it('Should prefer local method headers when both global and local method options headers are defined', () => { | |||
| expect(combineCustomHeaders(globalOptions, methodOptions)).to.deep.equal(methodOptions.headers); | |||
| }); | |||
|
|
|||
| it('Should return the url without any modification', () => { | |||
There was a problem hiding this comment.
It looks like these tests are under the describe statement of another function (describe('combineCustomHeaders'...). Can we move them to a describe statement of their own?
There was a problem hiding this comment.
Yes, sure! Sorry about that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.