[CSL-3108] Trim space adjustments #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sblaurock
commented
Dec 19, 2023
src/modules/autocomplete.js
Outdated
| const queryTrimmed = helpers.trimNonBreakingSpaces(query); | ||
|
|
||
| // Validate query (term) is provided and consists of more than non-breaking spaces | ||
| if (!queryTrimmed || typeof queryTrimmed !== 'string') { |
There was a problem hiding this comment.
This was added to ensure we don't dispatch requests consisting of solely non-breaking spaces (ex: )
sblaurock
commented
Dec 19, 2023
src/modules/search.js
Outdated
| const queryTrimmed = helpers.trimNonBreakingSpaces(query); | ||
|
|
||
| // Validate query (term) is provided and consists of more than non-breaking spaces | ||
| if (!queryTrimmed || typeof queryTrimmed !== 'string') { |
There was a problem hiding this comment.
This was added to ensure we don't dispatch requests consisting of solely non-breaking spaces (ex: )
jjl014
approved these changes
Dec 19, 2023
spec/src/modules/search.js
Outdated
| @@ -6,6 +6,7 @@ const sinon = require('sinon'); | |||
| const sinonChai = require('sinon-chai'); | |||
| const ConstructorIO = require('../../../test/constructorio'); // eslint-disable-line import/extensions | |||
| const helpers = require('../../mocha.helpers'); | |||
| const utilsHelpers = require('../../../src/utils/helpers'); | |||
There was a problem hiding this comment.
Feel free to ignore this, but should we just import the specific function here so we don't have helpers and utilsHelpers? Haha
i.e. const { trimNonBreakingSpaces } = require('../../../src/utils/helpers');
There was a problem hiding this comment.
Great callout - this is going to go away anyway. We should not be trimming on search either
jjl014
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been raised that autocomplete requests should not have non-breaking spaces trimmed from queries (terms). This pull request aims to do the following:
a. No longer trim non-breaking spaces from autocomplete and search requests
b. Add tests to cover the above case.
Reference ticket: https://linear.app/constructor/issue/CSL-3108/investigate-error-with-space-input-in-constructorio-node