Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSL-2655] Update items parameter type in tracker module #166

Merged

Conversation

esezen
Copy link
Contributor

@esezen esezen commented Aug 8, 2023

@esezen esezen requested review from mocca102 and a team August 8, 2023 20:02
Copy link
Contributor

@mocca102 mocca102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that trackRecommendationView is missing items parameter in the function implementation. Can we fix that here as well?

@esezen esezen requested a review from mocca102 August 9, 2023 12:40
Copy link
Contributor

@mocca102 mocca102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@esezen esezen merged commit ca7a177 into master Aug 10, 2023
6 of 7 checks passed
@esezen esezen deleted the csl-2655-node-sdk-update-items-parameter-type-in-tracker-module branch August 10, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants