added guard for section query param

Constructor-io · Apr 5, 2024 · deeaaf3 · deeaaf3
1 parent 81fc913
commit deeaaf3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/spec/src/modules/recommendations.js b/spec/src/modules/recommendations.js
@@ -675,7 +675,7 @@ describe('ConstructorIO - Recommendations', () => {
       });
     });
 
-    it('Should add the section query param when section parameter is provided', (done) => {
+    it.only('Should add the section query param when section parameter is provided', (done) => {
       const { recommendations } = new ConstructorIO({
         ...validOptions,
         fetch: fetchSpy,
@@ -691,7 +691,7 @@ describe('ConstructorIO - Recommendations', () => {
       });
     });
 
-    it('Should not add the section query param if it is not provided', (done) => {
+    it.only('Should not add the section query param if it is not provided', (done) => {
       const { recommendations } = new ConstructorIO({
         ...validOptions,
         fetch: fetchSpy,

diff --git a/src/modules/recommendations.js b/src/modules/recommendations.js
@@ -216,7 +216,8 @@ class Recommendations {
     const controller = new AbortController();
     const { signal } = controller;
     const headers = {};
-    const rawQueryParams = qs.stringify(parameters);
+    const { section } = parameters;
+    const rawQueryParams = section ? qs.stringify({ section }) : '';
     const queryParams = rawQueryParams ? `&${rawQueryParams}` : '';
     const requestUrl = `${serviceUrl}/v1/recommendation_pods?key=${apiKey}${queryParams}`.trim();