Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Deneb testnet config #960

Merged
merged 4 commits into from
Jan 10, 2024
Merged

Update Deneb testnet config #960

merged 4 commits into from
Jan 10, 2024

Conversation

jframe
Copy link
Contributor

@jframe jframe commented Jan 10, 2024 •
edited
Loading

PR Description

Deneb testnet config for upcoming testnet forks. Also removes blob sidecar signing as this is no longer necessary and the type has changed.

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Testing

  • I thought about testing these changes in a realistic/non-local environment.

usmansaleem
usmansaleem approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jframe jframe merged commit e9830b7 into Consensys:master Jan 10, 2024
7 checks passed
@jframe jframe deleted the deneb_testnet_config branch January 10, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usmansaleem usmansaleem usmansaleem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jframe @usmansaleem