Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add NVD API Key to dep check #952

Closed
wants to merge 7 commits into from
Closed

add NVD API Key to dep check #952

wants to merge 7 commits into from

Conversation

gfukushima
Copy link
Contributor

@gfukushima gfukushima commented Dec 5, 2023 •
edited
Loading

PR Description

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Testing

  • I thought about testing these changes in a realistic/non-local environment.

usmansaleem
usmansaleem approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gfukushima gfukushima closed this Dec 5, 2023
@gfukushima gfukushima deleted the NVD-API-key branch December 5, 2023 03:30
@gfukushima gfukushima restored the NVD-API-key branch December 5, 2023 03:30
@gfukushima gfukushima reopened this Dec 5, 2023
@gfukushima gfukushima marked this pull request as draft December 6, 2023 01:05
@gfukushima gfukushima closed this Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usmansaleem usmansaleem usmansaleem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gfukushima @usmansaleem @joshuafernandes