Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency check upgrade and supress FP #951

Merged
merged 6 commits into from
Dec 4, 2023
Merged

Dependency check upgrade and supress FP #951

merged 6 commits into from
Dec 4, 2023

Conversation

gfukushima
Copy link
Contributor

@gfukushima gfukushima commented Nov 30, 2023 •
edited
Loading

PR Description

This PR upgrades the dependency check version and adds a supression to a false positive to the azure-core libraries not related to the Azure CLI CVE reported. Already has an issue raised in jeremylong/DependencyCheck#6100

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Testing

  • I thought about testing these changes in a realistic/non-local environment.

usmansaleem
usmansaleem approved these changes Dec 3, 2023
View reviewed changes
Copy link
Contributor

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gfukushima gfukushima merged commit c4189fd into Consensys:master Dec 4, 2023
2 checks passed
@jframe jframe mentioned this pull request Dec 6, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jframe jframe jframe approved these changes

@usmansaleem usmansaleem usmansaleem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gfukushima @usmansaleem @jframe